Xymon Mailing List Archive search

4.3.2 bug, comma before HISTORY button

4 messages in this thread

list David W Gore · Fri, 15 Apr 2011 13:21:55 +0000 · 
Looks like a bug in 4.3.2.  There is a comma before the HISTORY button.
We can see this on our site as well as on Henrik's.

 
~David
list David W Gore · Fri, 15 Apr 2011 14:10:28 +0000 · 
Apparently an extra comma on line 74 of lib/htmllog.c

~David
▸ quoted from David W Gore

From: Gore, David W 
Sent: Friday, April 15, 2011 13:22
To: 'xymon at xymon.com'
Subject: [Xymon] 4.3.2 bug, comma before HISTORY button

Looks like a bug in 4.3.2.  There is a comma before the HISTORY button.  We can see this on our site as well as on Henrik's.


~David
list Henrik Størner · Sun, 17 Apr 2011 22:16:06 +0200 ·
▸ quoted from David W Gore
Looks like a bug in 4.3.2. There is a comma before the HISTORY button.
We can see this on our site as well as on Henrik’s.
Correct, this snuck into the 4.3.2 update unfortunately.


Regards,
Henrik
list Asif Iqbal · Tue, 26 Apr 2011 15:00:41 -0400 ·
▸ quoted from Henrik Størner
On Sun, Apr 17, 2011 at 4:16 PM, Henrik Størner <user-ce4a2c883f75@xymon.invalid> wrote:
Looks like a bug in 4.3.2. There is a comma before the HISTORY button.
We can see this on our site as well as on Henrik’s.
Correct, this snuck into the 4.3.2 update unfortunately.
so as David Gore pointed out line 74 on lib/htmllog.c looks like this

fprintf(output, "<BR><BR><CENTER><FORM ACTION=\"%s/history.sh\">,", cgibinurl);

so replace it with

fprintf(output, "<BR><BR><CENTER><FORM ACTION=\"%s/history.sh\">", cgibinurl);

and then gmake clean; gmake; gmake install ?

or there is a safer way recommended ?


Regards,
Henrik


-- 
Asif Iqbal
PGP Key: 0xE62693C5 KeyServer: pgp.mit.edu
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?