Double combo - display &unknown - xymon 4.3.28
list Dominique Delporte
I have the same problem as in the thread https://lists.xymon.com/archive/2011-September/032469.html Where a patch was suggested here : https://lists.xymon.com/archive/2011-September/032481.html But in fact the problem is always present with combo of combo. I found the solution : update color value in function getstatus So I propose this patch, just adding one line to update color : *color = (walk->result ? COL_GREEN : COL_RED); --- combostatus.c.orig 2019-09-03 14:46:39.221984375 +0200 +++ combostatus.c 2019-09-03 14:50:42.412165047 +0200 @@ -251,6 +251,7 @@ for (walk = testhead; (walk && ( (strcmp(walk->reshostname, hostname) != 0) || (strcmp(walk->restestname, testname) != 0) ) ); walk = walk->next); if (walk != NULL) { /* It is a combo test they want the result of. */ + *color = (walk->result ? COL_GREEN : COL_RED); return walk->result; } dominique DELPORTE
list Japheth Cleaver
Hi, Thanks for the patch. I've confirmed the issue was still there and this does fix it. Applied to 4.3.30. Regards, -jc
▸
On 9/3/2019 7:05 AM, Dominique Delporte wrote:I have the same problem as in the thread https://lists.xymon.com/archive/2011-September/032469.html Where a patch was suggested here : https://lists.xymon.com/archive/2011-September/032481.html But in fact the problem is always present with combo of combo. I found the solution : update color value in function getstatus So I propose this patch, just adding one line to update color : *color = (walk->result ? COL_GREEN : COL_RED); --- combostatus.c.orig 2019-09-03 14:46:39.221984375 +0200 +++ combostatus.c 2019-09-03 14:50:42.412165047 +0200 @@ -251,6 +251,7 @@ ? for (walk = testhead; (walk && ( (strcmp(walk->reshostname, hostname) != 0) || (strcmp(walk->restestname, testname) != 0) ) ); walk = walk->next); ? if (walk != NULL) { ? /* It is a combo test they want the result of. */ + *color = (walk->result ? COL_GREEN : COL_RED); ? return walk->result; ? }