Xymon Mailing List Archive search

xymon.sh: add return codes for status

3 messages in this thread

list Nikolai Lifanov · Wed, 27 Jan 2016 15:00:14 -0500 ·
Can you please add LSB return codes to either the init script or
xymon.sh please? A sample implementation:

--- trunk/files/xymon/usr/lib/xymon/server/bin/xymon.sh	Wed Jan 27
14:41:07 2016	(r6869)
+++ trunk/files/xymon/usr/lib/xymon/server/bin/xymon.sh	Wed Jan 27
14:42:58 2016	(r6870)
@@ -56,12 +56,15 @@
 		if test $? -eq 0
 		then
 			echo "Xymon (xymonlaunch) running with PID `cat
/var/log/xymon/xymonlaunch.pid`"
+			exit 0
 		else
 			echo "Xymon not running, removing stale PID file"
 			rm -f /var/log/xymon/xymonlaunch.pid
+			exit 1
 		fi
 	else
 		echo "Xymon (xymonlaunch) does not appear to be running"
+		exit 3
 	fi
 	;;


See "status" under this page:
http://refspecs.linuxbase.org/LSB_3.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html
list Japheth Cleaver · Wed, 27 Jan 2016 13:21:18 -0800 ·
quoted from Nikolai Lifanov

On Wed, January 27, 2016 12:00 pm, Nikolai Lifanov wrote:
Can you please add LSB return codes to either the init script or
xymon.sh please? A sample implementation:
Hi,

Thanks, this has been committed in on 4.3.25, with pass-through calls for
the rpm/* scripts. (The debian/* versions were already doing this.)

https://sourceforge.net/p/xymon/code/7884


"trunk" development is basically occurring in 4.x-master for now...
An upcoming commit there combines the runclient.sh and xymon.sh scripts
into their init counterparts, as more and more pre-xymonlaunch
configuration can be eliminated.


Regards,
-jc
list Nikolai Lifanov · Wed, 27 Jan 2016 18:55:44 -0500 ·
Thank you! I patched both to play nice with my configuration management system.

- Nikolai Lifanov
quoted from Japheth Cleaver

On January 27, 2016 4:21:18 PM EST, "J.C. Cleaver" <user-87556346d4af@xymon.invalid> wrote:

On Wed, January 27, 2016 12:00 pm, Nikolai Lifanov wrote:
Can you please add LSB return codes to either the init script or
xymon.sh please? A sample implementation:
Hi,

Thanks, this has been committed in on 4.3.25, with pass-through calls
for
the rpm/* scripts. (The debian/* versions were already doing this.)

https://sourceforge.net/p/xymon/code/7884


"trunk" development is basically occurring in 4.x-master for now...
An upcoming commit there combines the runclient.sh and xymon.sh scripts
into their init counterparts, as more and more pre-xymonlaunch
configuration can be eliminated.


Regards,
-jc
-- 

Sent from my Android device with K-9 Mail. Please excuse my brevity.