PATCH: RRD Graph Colours
list Malcolm Hunter
Hi, Attached is a patch that allows users to customise the colour of the RRD graphs (default is black on white). To change colours (e.g. to white on black), add the following to xymonserver.cfg: RRDFONTCOLOR="#FFFFFF" RRDBACKCOLOR="#000000" Regards, Malcolm -- BBWin Development - The Windows client for Big Brother and Xymon http://bbwin.sourceforge.net http://xymon.sourceforge.net
list Malcolm Hunter
Oops! 2nd time I've done this today and forgotten to attach the file.
▸
----- Original Message ----- From: Malcolm Hunter Sent: 01/19/12 03:41 PM To: user-834d44be5e50@xymon.invalid, Xymon at xymon.com Subject: [Xymon] PATCH: RRD Graph Colours Hi, Attached is a patch that allows users to customise the colour of the RRD graphs (default is black on white). To change colours (e.g. to white on black), add the following to xymonserver.cfg: RRDFONTCOLOR="#FFFFFF" RRDBACKCOLOR="#000000" Regards, Malcolm -- BBWin Development - The Windows client for Big Brother and Xymon http://bbwin.sourceforge.net http://xymon.sourceforge.net
-- BBWin Development - The Windows client for Big Brother and Xymon http://bbwin.sourceforge.net http://xymon.sourceforge.net
Attachments (1)
list Malcolm Hunter
Updated patch for the showgraph.c file - fixes issue zooming in on CPU graphs.
▸
----- Original Message ----- From: Malcolm Hunter Sent: 01/19/12 03:44 PM To: user-834d44be5e50@xymon.invalid, Xymon at xymon.com Subject: Re: [Xymon] PATCH: RRD Graph Colours Oops! 2nd time I've done this today and forgotten to attach the file.----- Original Message ----- From: Malcolm Hunter Sent: 01/19/12 03:41 PM To: user-834d44be5e50@xymon.invalid, Xymon at xymon.com Subject: [Xymon] PATCH: RRD Graph ColoursHi, Attached is a patch that allows users to customise the colour of the RRD graphs (default is black on white). To change colours (e.g. to white on black), add the following to xymonserver.cfg: RRDFONTCOLOR="#FFFFFF"RRDBACKCOLOR="#000000"Regards,Malcolm -- BBWin Development - The Windows client for Big Brother and Xymonhttp://bbwin.sourceforge.net http://xymon.sourceforge.net-- BBWin Development - The Windows client for Big Brother and Xymon http://bbwin.sourceforge.net http://xymon.sourceforge.net
-- BBWin Development - The Windows client for Big Brother and Xymon http://bbwin.sourceforge.net http://xymon.sourceforge.net
Attachments (1)
list Bruce White
Can someone supply instructions on how to apply this patch? My 4.3.7 install has the issue. Thanks, Bruce Bruce White Senior Enterprise Systems Engineer | Phone: X-XXX-XXX-XXXX | Fax: XXX-XXX-XXXX | user-58f975e8bf9d@xymon.invalid | http://www.fellowes.com/ Disclaimer: The information contained in this message may be privileged and confidential and protected from disclosure. If the reader of this message is not the intended recipient or an employee or agent responsible for delivering this message to the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify us immediately by replying to the message and deleting it from your computer. Thank you. Fellowes, Inc.
▸
-----Original Message-----
From: xymon-bounces at xymon.com [mailto:xymon-bounces at xymon.com] On Behalf Of Malcolm Hunter
Sent: Thursday, January 19, 2012 12:07 PM
To: user-834d44be5e50@xymon.invalid; Xymon at xymon.com
Subject: Re: [Xymon] PATCH: RRD Graph Colours
Updated patch for the showgraph.c file - fixes issue zooming in on CPU graphs.
----- Original Message ----- From: Malcolm Hunter Sent: 01/19/12 03:44 PM To: user-834d44be5e50@xymon.invalid, Xymon at xymon.com Subject: Re: [Xymon] PATCH: RRD Graph Colours Oops! 2nd time I've done this today and forgotten to attach the file.----- Original Message ----- From: Malcolm Hunter Sent: 01/19/12 03:41 PM To: user-834d44be5e50@xymon.invalid, Xymon at xymon.com Subject: [Xymon] PATCH: RRD Graph Colours Hi, Attached is a patch that allows users to customise the colour of the RRD graphs (default is black on white). To change colours (e.g. to white on black), add the following to xymonserver.cfg: RRDFONTCOLOR="#FFFFFF" RRDBACKCOLOR="#000000" Regards, Malcolm -- BBWin Development - The Windows client for Big Brother and Xymon http://bbwin.sourceforge.net http://xymon.sourceforge.net-- BBWin Development - The Windows client for Big Brother and Xymon http://bbwin.sourceforge.net http://xymon.sourceforge.net
-- BBWin Development - The Windows client for Big Brother and Xymon http://bbwin.sourceforge.net http://xymon.sourceforge.net
list Josh Luthman
http://linux.die.net/man/1/patch Usually patch file.c file.c.patch Then I think a ./configure && make && make install again. Might not need a ./configure but I don't think it would hurt. Josh Luthman Office: XXX-XXX-XXXX Direct: XXX-XXX-XXXX XXXX Wayne St Suite XXXX Troy, OH XXXXX
▸
On Fri, Jan 20, 2012 at 9:52 AM, White, Bruce <user-58f975e8bf9d@xymon.invalid> wrote:Can someone supply instructions on how to apply this patch? My 4.3.7 install has the issue. Thanks, Bruce Bruce White Senior Enterprise Systems Engineer | Phone: X-XXX-XXX-XXXX | Fax: XXX-XXX-XXXX | user-58f975e8bf9d@xymon.invalid | http://www.fellowes.com/ Disclaimer: The information contained in this message may be privileged and confidential and protected from disclosure. If the reader of this message is not the intended recipient or an employee or agent responsible for delivering this message to the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify us immediately by replying to the message and deleting it from your computer. Thank you. Fellowes, Inc. -----Original Message----- From: xymon-bounces at xymon.com [mailto:xymon-bounces at xymon.com] On Behalf Of Malcolm Hunter Sent: Thursday, January 19, 2012 12:07 PM To: user-834d44be5e50@xymon.invalid; Xymon at xymon.com Subject: Re: [Xymon] PATCH: RRD Graph Colours Updated patch for the showgraph.c file - fixes issue zooming in on CPU graphs.----- Original Message ----- From: Malcolm Hunter Sent: 01/19/12 03:44 PM To: user-834d44be5e50@xymon.invalid, Xymon at xymon.com Subject: Re: [Xymon] PATCH: RRD Graph Colours Oops! 2nd time I've done this today and forgotten to attach the file.----- Original Message ----- From: Malcolm Hunter Sent: 01/19/12 03:41 PM To: user-834d44be5e50@xymon.invalid, Xymon at xymon.com Subject: [Xymon] PATCH: RRD Graph Colours Hi, Attached is a patch that allows users to customise the colour of the RRD graphs (default is black on white). To change colours (e.g. to white on black), add the following to xymonserver.cfg: RRDFONTCOLOR="#FFFFFF" RRDBACKCOLOR="#000000" Regards, Malcolm -- BBWin Development - The Windows client for Big Brother and Xymon http://bbwin.sourceforge.net http://xymon.sourceforge.net-- BBWin Development - The Windows client for Big Brother and Xymon http://bbwin.sourceforge.net http://xymon.sourceforge.net-- BBWin Development - The Windows client for Big Brother and Xymon http://bbwin.sourceforge.net http://xymon.sourceforge.net
list Malcolm Hunter
▸
----- Original Message ----- From: White, Bruce Sent: 01/20/12 02:52 PM To: Malcolm Hunter, user-834d44be5e50@xymon.invalid, Xymon at xymon.com Subject: RE: [Xymon] PATCH: RRD Graph Colours Can someone supply instructions on how to apply this patch? My 4.3.7 install has the issue.
As Josh replied, it's just a matter of extracting the files and running `patch original.c patch.c.patch` then re-running make and `make install`. The patches do throw a few non-fatal errors when applied to the Subversion tree (trunk r6890 and branch 4.3.7), so I've attached revised patches (tarball this time).
▸
Malcolm -- BBWin Development - The Windows client for Big Brother and Xymon http://bbwin.sourceforge.net http://xymon.sourceforge.net
Attachments (1)
list Bruce White
Malcolm, Thanks! I will retry using your tar ball. When I applied the patch from the file I downloaded I got several fatal errors and the process rejected much of the patch (see attached rej file). I ended up applying the patch by hand, but it only fixed some of my graphs not zooming properly. I will go back now and try your tar ball to see if it fixes all my zoom issues.
▸
......Bruce Bruce White Senior Enterprise Systems Engineer | Phone: X-XXX-XXX-XXXX | Fax: XXX-XXX-XXXX | user-58f975e8bf9d@xymon.invalid | http://www.fellowes.com/ Disclaimer: The information contained in this message may be privileged and confidential and protected from disclosure. If the reader of this message is not the intended recipient or an employee or agent responsible for delivering this message to the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify us immediately by replying to the message and deleting it from your computer. Thank you. Fellowes, Inc. -----Original Message-----
▸
From: xymon-bounces at xymon.com [mailto:xymon-bounces at xymon.com] On Behalf Of Malcolm Hunter
Sent: Saturday, January 21, 2012 5:20 AM
To: Xymon at xymon.com
Subject: Re: [Xymon] PATCH: RRD Graph Colours
----- Original Message ----- From: White, Bruce Sent: 01/20/12 02:52 PM To: Malcolm Hunter, user-834d44be5e50@xymon.invalid, Xymon at xymon.com Subject: RE: [Xymon] PATCH: RRD Graph Colours Can someone supply instructions on how to apply this patch? My 4.3.7 install has the issue.
As Josh replied, it's just a matter of extracting the files and running `patch original.c patch.c.patch` then re-running make and `make install`. The patches do throw a few non-fatal errors when applied to the Subversion tree (trunk r6890 and branch 4.3.7), so I've attached revised patches (tarball this time). Malcolm -- BBWin Development - The Windows client for Big Brother and Xymon http://bbwin.sourceforge.net http://xymon.sourceforge.net
Attachments (1)
list Malcolm Hunter
Hi Bruce,
▸
----- Original Message ----- From: White, Bruce Sent: 01/21/12 08:45 PM To: Malcolm Hunter, Xymon at xymon.com Subject: RE: [Xymon] PATCH: RRD Graph Colours Malcolm, Thanks! I will retry using your tar ball. When I applied the patch from the file I downloaded I got several fatal errors and the process rejected much of the patch (see attached rej file). I ended up applying the patch by hand, but it only fixed some of my graphs not zooming properly. I will go back now and try your tar ball to see if it fixes all my zoom issues.
The errors should be fixed in the new tarball. The zooming issue was a bug that my original patch introduced. Your problem is most likely caused by something else. What is the problem exactly and does it occur on different web browsers?
▸
Malcolm -- BBWin Development - The Windows client for Big Brother and Xymon http://bbwin.sourceforge.net http://xymon.sourceforge.net
list Henrik Størner
Hi Malcolm, On Thu, 19 Jan 2012 16:41:44 +0100, "Malcolm Hunter"
▸
<user-8c18ec239c05@xymon.invalid> wrote:Hi, Attached is a patch that allows users to customise the colour of the RRD graphs (default is black on white). To change colours (e.g. to white on black), add the following to xymonserver.cfg: RRDFONTCOLOR="#FFFFFF" RRDBACKCOLOR="#000000"
I'm not really happy with this. I would really prefer to avoid any more hardcoded rrd-graph options in the code, especially when they are not required for Xymon to just show the graphs. E.g. your patch provides settings for the font- and background-colors. But what if you want to turn the grid off ? There's an rrdgraph option for that - should we provide yet another Xymon setting for it ? Instead, we should provide a simple way of adding whatever custom options for rrdgraph that you would like. And it should be possible to have both a global default, and a per-graph specific set of options. So how about this patch instead ? Untested, but it compiles and should be simple enough to "just work". You can either put the rrd_graph() options in RRDGRAPHOPTS in xymonserver.cfg, or provide an OPTIONS line in the graphs.cfg file for each graph. The per-graph setting takes precedence. Regards, Henrik
list Henrik Størner
▸
On Wed, 15 Feb 2012 14:35:46 +0100, <user-ce4a2c883f75@xymon.invalid> wrote:
So how about this patch instead ? Untested, but it compiles and should be simple enough to "just work". You can either put the rrd_graph() options in RRDGRAPHOPTS in xymonserver.cfg, or provide an OPTIONS line in the graphs.cfg file for each graph. The per-graph setting takes precedence.
Small correction: It's "GRAPHOPTIONS" in graphs.cfg. And I tested it now, it works. Regards, Henrik
list Malcolm Hunter
▸
----- Original Message ----- From: user-ce4a2c883f75@xymon.invalid Sent: 02/15/12 01:43 PM To: Malcolm Hunter Subject: Re: [Xymon-developer] PATCH: RRD Graph Colours On Wed, 15 Feb 2012 14:35:46 +0100, <user-ce4a2c883f75@xymon.invalid> wrote:So how about this patch instead ? Untested, but it compiles and should be simple enough to "just work". You can either put the rrd_graph() options in RRDGRAPHOPTS in xymonserver.cfg, or provide an OPTIONS line in the graphs.cfg file for each graph. The per-graph setting takes precedence.Small correction: It's "GRAPHOPTIONS" in graphs.cfg. And I tested it now, it works.
Excellent! This is a much better way of doing it. Thanks,
▸
Malcolm -- BBWin Development - The Windows client for Big Brother and Xymon http://bbwin.sourceforge.net http://xymon.sourceforge.net
list Malcolm Hunter
You need to apply this patch from Henrik to the source code. It works with trunk and 4.3.7 - not sure about earlier versions. Notes: You can either put the rrd_graph() options in RRDGRAPHOPTS in xymonserver.cfg, or provide a GRAPHOPTIONS line in the
▸
graphs.cfg file for each graph. The per-graph setting takes precedence. -- BBWin Development - The Windows client for Big Brother and Xymon http://bbwin.sourceforge.net http://xymon.sourceforge.net