Post-RC4 patch available 🔗 link

A couple of problems have shown up in RC4 - these have hopefully been
solved now.

The most spectacular bug was the repeated crashes that Brian Lynch
reported; it turned out that sending Hobbit a message larger then ~100
KB would crash hobbitd. There was code to catch this, it just didn't
work. Thanks a lot for Brian's help in tracking this down.

hobbitd_alert no longer crashes when trying to send a message. This
is the one-line fix sent out just after the RC4 was made available.

Another bug that's been resolved is the unexpected "green"
recovery-messages. Kevin Hanrahan actually found the cause for me, and
once you know what is going on it is so much easier to fix.

And the "route" tag is now working again for the network tests.


A patch for these issues is at http://www.hswn.dk/beta/post-RC4.patch

To install:

   cd hobbit-4.0-RC4
   patch -p0 </tmp/post-RC4.patch
   make clean
   make
   shutdown hobbit, run "make install" and start hobbit

Note that you must first un-install the one-line hobbitd_alert fix if
you installed this: Run "patch -R -p0 < RC4-hobbitd_alert-crash.patch"
to back out this patch.

If there are no obvious problems after this patch, I'm tempted to do
the official release next week.


Regards,
Henrik

Anybody get these errors during the patch install?


patching file Changes-4.0
patching file bbdisplay/bb-hist.c
patching file bbdisplay/bb-histlog.sh-hobbitd.DIST
patching file bbdisplay/bb-hist.sh-hobbitd.DIST
patching file bbdisplay/event_footer
patching file bbdisplay/event_header
patching file bbnet/bbtest-net.c
Hunk #2 FAILED at 466.
1 out of 2 hunks FAILED -- saving rejects to file bbnet/bbtest-net.c.rej
patching file build/ldap.sh
patching file build/Makefile.test-ssl
patching file build/merge-sects.c
patching file build/pcre.sh
patching file build/rrd.sh
patching file build/ssl.sh
patching file configure
patching file hobbitd/do_alert.c
Hunk #12 FAILED at 969.
1 out of 28 hunks FAILED -- saving rejects to file hobbitd/do_alert.c.rej
patching file hobbitd/do_larrd.c
patching file hobbitd/hobbit-alerts.cfg.5
patching file hobbitd/hobbitd_alert.c
patching file hobbitd/hobbitd.c
patching file hobbitd/hobbitd_channel.c
patching file hobbitd/hobbitd_filestore.c
patching file hobbitd/hobbitd_history.c
patching file hobbitd/hobbitd_ipc.c
patching file hobbitd/hobbitd_larrd.c
patching file hobbitd/hobbitd_worker.c
patching file hobbitd/larrd/do_bea.c
patching file hobbitd/larrd/do_external.c
patching file hobbitd/larrd/do_hobbitd.c
patching file hobbitd/larrd/do_iostat.c
patching file hobbitd/larrd/do_sendmail.c
patching file hobbitd/starthobbit.sh.DIST
patching file lib/htmllog.c
patching file lib/memory.c
patching file lib/netservices.c
patching file lib/url.c


                    Henrik                                                                                    
                    Stoerner             To:     user-ae9b8668bcde@xymon.invalid                                               
                    <henrik at hswn.        cc:                                                                  
                    dk>                  Subject:     [hobbit] Post-RC4 patch available                       
                                                                                                              
                    03/03/2005                                                                                
                    03:43 AM                                                                                  
                    Please                                                                                    
                    respond to                                                                                
                    hobbit                                                                                    

                                                                                                              
                                                                                                              
A couple of problems have shown up in RC4 - these have hopefully been
solved now.

The most spectacular bug was the repeated crashes that Brian Lynch
reported; it turned out that sending Hobbit a message larger then ~100
KB would crash hobbitd. There was code to catch this, it just didn't
work. Thanks a lot for Brian's help in tracking this down.

hobbitd_alert no longer crashes when trying to send a message. This
is the one-line fix sent out just after the RC4 was made available.

Another bug that's been resolved is the unexpected "green"
recovery-messages. Kevin Hanrahan actually found the cause for me, and
once you know what is going on it is so much easier to fix.

And the "route" tag is now working again for the network tests.


A patch for these issues is at http://www.hswn.dk/beta/post-RC4.patch

To install:

   cd hobbit-4.0-RC4
   patch -p0 </tmp/post-RC4.patch
   make clean
   make
   shutdown hobbit, run "make install" and start hobbit

Note that you must first un-install the one-line hobbitd_alert fix if
you installed this: Run "patch -R -p0 < RC4-hobbitd_alert-crash.patch"
to back out this patch.

If there are no obvious problems after this patch, I'm tempted to do
the official release next week.


Regards,
Henrik

On Thu, Mar 03, 2005 at 09:51:30AM -0600, Rick Waegner wrote:

I think you applied the patch on top of some of the early patches -
looks like the "route" handling patch and the hobbitd_alert
crash-patch havent been un-installed.

It should be OK, I think. If in doubt, unpack the RC4 sources, apply
the patch and re-run configure (or copy over the Makefile).


Henrik