Xymon Mailing List Archive search

Display issues with SMTP and FTP status pages - 4.2RC20060712

3 messages in this thread

list Bob Gordon · Mon, 31 Jul 2006 23:09:47 -0700 ·
Hello -

I installed the 4.2RC20060712 system today and I am noticing some formatting
issues with the status noted above the graph on the SMTP and FTP pages..
Not sure if it affects other pages as well.

Mon Jul 31 22:52:14 2006 smtp ok

Service smtp on monitor is OK (up)


220  ESMTP..250-monitor Hello monitor [10.5.142.16], pleased to meet
you..250-ENHANCEDSTATUSCODES..250-PIPELINING..250-8BITMIME..250-SIZE
83886080..250-DELIVERBY..250 HELP..250 2.1.0 monitor at monitor... Sender
ok..221 2.0.0 monitor closing connection..

Seconds: 0.03

In version 4.1.2, each response was on its own line...

220 ESMTP
250-monitor Hello monitor [10.5.142.16], pleased to meet you
250-ENHANCEDSTATUSCODES
250-PIPELINING
250-8BITMIME
250-SIZE 83886080
250-DELIVERBY
250 HELP
250 2.1.0 monitor at monitor... Sender ok
221 2.0.0 monitor closing connection


Any ideas on how I can fix the output in the 4.2RC version?

Thanks!

-- 
--==[ Bob Gordon ]==--
list Henrik Størner · Tue, 1 Aug 2006 09:23:12 +0200 ·
quoted from Bob Gordon
On Mon, Jul 31, 2006 at 11:09:47PM -0700, Bob Gordon wrote:
I installed the 4.2RC20060712 system today and I am noticing some formatting
issues with the status noted above the graph on the SMTP and FTP pages..
Not sure if it affects other pages as well.

Mon Jul 31 22:52:14 2006 smtp ok

Service smtp on monitor is OK (up)


220  ESMTP..250-monitor Hello monitor [10.5.142.16], pleased to meet
you..250-ENHANCEDSTATUSCODES..250-PIPELINING..250-8BITMIME..250-SIZE
83886080..250-DELIVERBY..250 HELP..250 2.1.0 monitor at monitor... Sender
ok..221 2.0.0 monitor closing connection..
It is a bit over-zealous in weeding out binary data from the 
banner texts. This patch for the network tester should make it more
like it used to be.


Regards,
Henrik

-------------- next part --------------
--- bbnet/bbtest-net.c	2006/07/21 14:49:56	1.239
+++ bbnet/bbtest-net.c	2006/08/01 07:20:22
@@ -2318,7 +2318,7 @@
 
 					/* Binary data in banner ... */
 					for (i=0, p=STRBUF(t->banner); (i < STRBUFLEN(t->banner)); i++, p++) {
-						if (!isprint((int)*p)) *p = '.';
+						if (!isprint((int)*p) && !isspace((int)*p)) *p = '.';
 					}
 				}
 			}
list Bob Gordon · Tue, 1 Aug 2006 02:00:48 -0700 ·
quoted from Henrik Størner
On 8/1/06, Henrik Stoerner <user-ce4a2c883f75@xymon.invalid> wrote:
It is a bit over-zealous in weeding out binary data from the
banner texts. This patch for the network tester should make it more
like it used to be.
Thank you for the patch.  Exactly what was needed...   :)

-- 
--==[ Bob Gordon ]==--