Xymon Mailing List Archive search

Workflow? - Call for 4.3.29 Patches

3 messages in this thread

list Frank Kannemann · Fri, 29 Mar 2019 09:25:41 -0400 · 
Hi Everyone,

I have been lurking and using xymon 4.3.28 for over a year now... Thanks to
all it is a great tool!

Just a quick question regarding submitting patches?

I think there are many ways to do so :-)...JC you seem to be the main
"driver" (thank you btw) so what is your preference?

It seems github fork and pull requests are the current standard? Is this
method okay for you?

Sorry if this a FAQ..?

Thx!

Frank
list Japheth Cleaver · Fri, 29 Mar 2019 08:29:59 -0700 ·
▸ quoted from Frank Kannemann
On 3/29/2019 6:25 AM, Frank Kannemann wrote:
Hi Everyone,

I have been lurking and using xymon 4.3.28 for over a year now... Thanks to all it is a great tool!

Just a quick question regarding submitting patches?

I think there are many ways to do so :-)...JC you seem to be the main "driver" (thank you btw) so what is your preference?

It seems github fork and pull requests are the current standard? Is this method okay for you?
Hi,

With the project being on SourceForge, patches against 4.3.28 (or the 4.3.29 branch, if it's an area that's already been touched) via email are preferred.

I think calling them out via [PATCH] in the future might be a good idea, just so they stand out.

A move to a git-based system might be possible in the future, in which case the standard PR model would probably be sufficient.

HTH,

-jc
list Frank Kannemann · Fri, 29 Mar 2019 11:47:57 -0400 · 
Cool, thanks!

On Fri, Mar 29, 2019 at 11:30 AM Japheth Cleaver <user-87556346d4af@xymon.invalid>
▸ quoted from Japheth Cleaver
wrote:

On 3/29/2019 6:25 AM, Frank Kannemann wrote:
Hi Everyone,

I have been lurking and using xymon 4.3.28 for over a year now...
Thanks to all it is a great tool!

Just a quick question regarding submitting patches?

I think there are many ways to do so :-)...JC you seem to be the main
"driver" (thank you btw) so what is your preference?

It seems github fork and pull requests are the current standard? Is
this method okay for you?
Hi,

With the project being on SourceForge, patches against 4.3.28 (or the
4.3.29 branch, if it's an area that's already been touched) via email
are preferred.

I think calling them out via [PATCH] in the future might be a good idea,
just so they stand out.

A move to a git-based system might be possible in the future, in which
case the standard PR model would probably be sufficient.

HTH,

-jc