4.0.3rc1 available
list Henrik Størner
I've put together a 4.0.3rc1 package - it's available at http://www.hswn.dk/beta/hobbit-4.0.3rc1.tar.gz This obviously has all the fixes that have been patched since the 4.0.2 release. It also includes the new enable/disable tool - there's no man-page for it yet, but I'll write one before the release. I have improved on this compared to the "maintenance-feature-v2" patch, by adding a simple way of enabling all tests for a host, or even multiple tests for all hosts. In other words, I think this one should satisfy everyone here. And hopefully it will also work on HP-UX; I think I understand the CGI "POST" specs now. Paul Backer's favicons are also in there. Based on the feedback last week, I decided to rip out the Big Brother compatibility code that had accumulated in Hobbit. (Just the BB server compatibility code - Hobbit still works fine with BB clients). It wasn't a lot of code, actually: This was almost entirely confined to the "bbgen" tool and how it loads the current state of Hobbit when it builds the webpages. So most of this clean-up job was going through the documentation, but it did result in a much needed cleanup of the purple-handling code in bbgen. So "--purplelog" actually works now. The full Changelog is below. I expect this to be very close to the final 4.0.3, but I would like it to have a bit of testing with you - especially the final version of the enable/disable tool, and any breakage caused by the removal of BB compatibility. Note that if you upgrade, then the ~/data/www/menu/menu_items.js file will *not* automatically be changed to point at the new "hobbit-enadis.sh" tool instead of "maint.pl" - you'll need to do that change by hand. Regards, Henrik Changes from 4.0.2 -> 4.0.3 Bugfixes: * Acknowledgments were broken in 4.0.2. * Fix file-descriptor leak in the "setup-newfiles" tool used during installation. This could cause "make install" to abort while installing new files, on systems with a low setting for the max. number of simultaneous open files. * The BBALPHAMSG text passed to scripts as a default alert message now includes the URL link to the statuslog. * Some header/footer files for the snapshot report HTML docs were missing. * The bb-datepage CGI tool was reading the POST data in an incorrect way; it worked on most systems, but did not adhere to the CGI specification. * The "info_header" and "info_footer" files were not being used for the "info" column pages. * Using PAGE=... in hobbit-alerts.cfg to pick out hosts on the front-page was not possible. The front page is now recognized with the name "/", so PAGE=/ will find them. * hobbitgraph.cgi could show "@RRDPARAM@" on graphs if it was matched by a NULL string (would happen for mailq graphs). * The "disk1" graph definition failed to take into account that the numbers logged were already in KB of data. So the axis-label was wrong. * RRD files were not being updated while a status was blue (disabled), even though status messages were received. Changed so that blue logs are passed off to the RRD parser - we might as well track data when it's there. * The "mailq" RRD handler now finds the queue-length regardless of whether it is before or after the "requests" keyword in the "mailq" or "nmailq" status message. Improvements: * All remnants of Big Brother compatibility have been removed. If you want to stick with the old Big Brother tool, use bbgen. This allowed for some much needed cleaning up of the bbgen code that loaded the status data, especially for the handling of purple status logs. * The maint.pl script has been removed. A new tool, hobbit-enadis.cgi, replaces this with a native Hobbit tool. If you are upgrading, you should change the ~/server/www/menu/menu_items.js file to point link to "hobbit-enadis.sh" instead of "maint.pl". * The "info" column page now includes a form to disable and enable tests for a single host. If you prefer not to have this on the info page, add the option "--no-disable" to the hobbit-cgi/bb-hostsvc.sh wrapper. * The hobbit-mailack CGI will now find a "delay=DURATION" line in the mail message, and use that as the duration of the acknowledgment. Reports show that there are some types of mail/SMS systems where you cannot modify the message subject. * Paul D. Backer contributed "favicon" images generated from the Hobbit "recent" GIF files. These have been added and are now loaded from the Hobbit web/*_header files, so that browsers supporting this (Mozilla, Firefox) will display a favicon-image in the titlebar or on the page-tab holding the Hobbit webpage.
list David Gore
▸
Henrik Stoerner wrote:
I've put together a 4.0.3rc1 package - it's available at http://www.hswn.dk/beta/hobbit-4.0.3rc1.tar.gz This obviously has all the fixes that have been patched since the 4.0.2 release. It also includes the new enable/disable tool - there's no man-page for it yet, but I'll write one before the release. I have improved on this compared to the "maintenance-feature-v2" patch, by adding a simple way of enabling all tests for a host, or even multiple tests for all hosts. In other words, I think this one should satisfy everyone here. And hopefully it will also work on HP-UX; I think I understand the CGI "POST" specs now. Paul Backer's favicons are also in there. Based on the feedback last week, I decided to rip out the Big Brother compatibility code that had accumulated in Hobbit. (Just the BB server compatibility code - Hobbit still works fine with BB clients). It wasn't a lot of code, actually: This was almost entirely confined to the "bbgen" tool and how it loads the current state of Hobbit when it builds the webpages. So most of this clean-up job was going through the documentation, but it did result in a much needed cleanup of the purple-handling code in bbgen. So "--purplelog" actually works now. The full Changelog is below. I expect this to be very close to the final 4.0.3, but I would like it to have a bit of testing with you - especially the final version of the enable/disable tool, and any breakage caused by the removal of BB compatibility. Note that if you upgrade, then the ~/data/www/menu/menu_items.js file will *not* automatically be changed to point at the new "hobbit-enadis.sh" tool instead of "maint.pl" - you'll need to do that change by hand. Regards, Henrik Changes from 4.0.2 -> 4.0.3 Bugfixes: * Acknowledgments were broken in 4.0.2. * Fix file-descriptor leak in the "setup-newfiles" tool used during installation. This could cause "make install" to abort while installing new files, on systems with a low setting for the max. number of simultaneous open files. * The BBALPHAMSG text passed to scripts as a default alert message now includes the URL link to the statuslog. * Some header/footer files for the snapshot report HTML docs were missing. * The bb-datepage CGI tool was reading the POST data in an incorrect way; it worked on most systems, but did not adhere to the CGI specification. * The "info_header" and "info_footer" files were not being used for the "info" column pages. * Using PAGE=... in hobbit-alerts.cfg to pick out hosts on the front-page was not possible. The front page is now recognized with the name "/", so PAGE=/ will find them. * hobbitgraph.cgi could show "@RRDPARAM@" on graphs if it was matched by a NULL string (would happen for mailq graphs). * The "disk1" graph definition failed to take into account that the numbers logged were already in KB of data. So the axis-label was wrong. * RRD files were not being updated while a status was blue (disabled), even though status messages were received. Changed so that blue logs are passed off to the RRD parser - we might as well track data when it's there. * The "mailq" RRD handler now finds the queue-length regardless of whether it is before or after the "requests" keyword in the "mailq" or "nmailq" status message. Improvements: * All remnants of Big Brother compatibility have been removed. If you want to stick with the old Big Brother tool, use bbgen. This allowed for some much needed cleaning up of the bbgen code that loaded the status data, especially for the handling of purple status logs. * The maint.pl script has been removed. A new tool, hobbit-enadis.cgi, replaces this with a native Hobbit tool. If you are upgrading, you should change the ~/server/www/menu/menu_items.js file to point link to "hobbit-enadis.sh" instead of "maint.pl". * The "info" column page now includes a form to disable and enable tests for a single host. If you prefer not to have this on the info page, add the option "--no-disable" to the hobbit-cgi/bb-hostsvc.sh wrapper. * The hobbit-mailack CGI will now find a "delay=DURATION" line in the mail message, and use that as the duration of the acknowledgment. Reports show that there are some types of mail/SMS systems where you cannot modify the message subject. * Paul D. Backer contributed "favicon" images generated from the Hobbit "recent" GIF files. These have been added and are now loaded from the Hobbit web/*_header files, so that browsers supporting this (Mozilla, Firefox) will display a favicon-image in the titlebar or on the page-tab holding the Hobbit webpage.
Replaced maint.pl in menu_items.js with hobbit-enadis.sh.
IE: blank page
Firefox: function isInternetExplorer() { if
(window.navigator.appName.indexOf("Internet Explorer") != -1) return
true; else return false; } function validateDisable(theform) { if
(theform.hostname.value == null || theform.hostname.value == "") {
alert("You must select the Host(s) to disable!");
theform.hostname.focus(); return false; } // Next validation works on
Mozilla, but does not work on MSIE browser if (! isInternetExplorer()) {
if (theform.disabletest.value
Putting maint.pl back in which works.
~David Gore
list Lars Ebeling
▸
David Gore <user-0ef10ea25696@xymon.invalid> wrote:
Replaced maint.pl in menu_items.js with hobbit-enadis.sh.
IE: blank page
Firefox: function isInternetExplorer() { if (window.navigator.appName.indexOf("Internet Explorer") != -1) return true; else return false; } function validateDisable(theform) { if (theform.hostname.value == null || theform.hostname.value == "") { alert("You must select the Host(s) to disable!"); theform.hostname.focus(); return false; } // Next validation works on Mozilla, but does not work on MSIE browser if (! isInternetExplorer()) { if (theform.disabletest.value
Putting maint.pl back in which works.
Here it seems like hobbit-enadis.sh works with both MSIE and Firefox.
Regards
Lars
Hobbithobbyist
"Never run after your own hat. Others will be delighted to do it; why spoil their fun?"
-- Mark Twain
list Henrik Størner
▸
On Tue, Apr 26, 2005 at 12:19:12AM +0000, David Gore wrote:
Henrik Stoerner wrote:I've put together a 4.0.3rc1 package - it's available at http://www.hswn.dk/beta/hobbit-4.0.3rc1.tar.gzReplaced maint.pl in menu_items.js with hobbit-enadis.sh. IE: blank page
Nothing at all ? Does anything show up if you do "View source" on this blank page ? What happens if you run the CGI by hand like this: REQUEST_METHOD="GET" ~hobbit/server/cgi-bin/hobbit-enadis.sh
Firefox: function isInternetExplorer() { if Even more strange. Could you try and copy the files from hobbit-4.0.3rc1/hobbitd/webfiles/maint* over to ~hobbit/server/web/ Just to be sure that the new templates got installed correctly. Thanks, Henrik
list Lars Ebeling
Had wrong subject, perhaps it was deleted.
▸
lars ebeling <user-b8ea1138b488@xymon.invalid> wrote:
Here it seems like hobbit-enadis.sh works with both MSIE and Firefox.
Regards
Lars
Some cosmetic things:
Perhaps the Filters should be above the selections for host and tests.
On the enableside selecting a host in All hosts show all tests not only disabled tests
▸
Regards
Lars
Hobbithobbyist
"Never run after your own hat. Others will be delighted to do it; why spoil their fun?"
-- Mark Twain
Hobbithobbyist
"Never run after your own hat. Others will be delighted to do it; why spoil their fun?"
-- Mark Twain
list Henrik Størner
▸
On Tue, Apr 26, 2005 at 08:31:18AM +0200, lars ebeling wrote:
Here it seems like hobbit-enadis.sh works with both MSIE and Firefox.
So no more hangs when you click the buttons for disable/enable ?
▸
Some cosmetic things: Perhaps the Filters should be above the selections for host and tests.
I tried that, but I think the most frequently used controls should be easily accessible - so I opted to have the host- and test-lists at the top.
▸
On the enableside selecting a host in All hosts show all tests not only disabled tests
I know. The disable-side uses some JavaScript stuff to swap in the set of tests that are available for that host. I just haven't gotten around to implement that over on the enable-side. Henrik
list Lars Ebeling
Henrik Stoerner <user-ce4a2c883f75@xymon.invalid> wrote: So no more hangs when you click the buttons for disable/enable ? No no hanging. Now I am going to try to play golf. Clear blue sky +8 C. That's the life of a Hobbithobbyist.
▸
Regards
Lars
Hobbithobbyist
"Never run after your own hat. Others will be delighted to do it; why spoil their fun?"
-- Mark Twain
list David Stuffle
▸
Henrik Stoerner wrote:
I've put together a 4.0.3rc1 package - it's available at http://www.hswn.dk/beta/hobbit-4.0.3rc1.tar.gz This obviously has all the fixes that have been patched since the 4.0.2 release. It also includes the new enable/disable tool - there's no man-page for it yet, but I'll write one before the release. I have improved on this compared to the "maintenance-feature-v2" patch, by adding a simple way of enabling all tests for a host, or even multiple tests for all hosts. In other words, I think this one should satisfy everyone here. And hopefully it will also work on HP-UX; I think I understand the CGI "POST" specs now.
On the new enable/disable tool, I have about 30 hosts disabled right now and the left side of the page lists all the hosts, which is a long list, and the right side has the "Select what to disable" heading at the top, but I have to scroll way down the page to see the Host and Test filter boxes. Can the right side of the page be top justified? New version looks good! Thanks ~~~~~~~~~~~~~~ David Stuffle Delta Faucet Company This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error please notify the system manager. Please note that any views or opinions presented in this email are solely those of the author and do not necessarily represent those of the company. Finally, the recipient should check this email and any attachments for the presence of viruses. The company accepts no liability for any damage caused by any virus transmitted by this email.
list David Stuffle
▸
Henrik Stoerner wrote:
I've put together a 4.0.3rc1 package - it's available at http://www.hswn.dk/beta/hobbit-4.0.3rc1.tar.gz This obviously has all the fixes that have been patched since the 4.0.2 release. It also includes the new enable/disable tool - there's no man-page for it yet, but I'll write one before the release. I have improved on this compared to the "maintenance-feature-v2" patch, by adding a simple way of enabling all tests for a host, or even multiple tests for all hosts. In other words, I think this one should satisfy everyone here. And hopefully it will also work on HP-UX; I think I understand the CGI "POST" specs now.
user-095ef1c764a2@xymon.invalidI spoke too soon. I have several views set up. If the last page I looked at was one of my views, then I go to the enable/disable page, all the hosts and tests are blank on the enable/disable page. I have to go back and click on the main page and then go back to the enable/disable page to see the hosts.
▸
~~~~~~~~~~~~~~
David Stuffle
Delta Faucet Company
This email and any files transmitted with it are confidential and intended
solely for the use of the individual or entity to whom they are addressed.
If you have received this email in error please notify the system manager.
Please note that any views or opinions presented in this email are solely
those of the author and do not necessarily represent those of the company.
Finally, the recipient should check this email and any attachments for the
presence of viruses. The company accepts no liability for any damage caused
by any virus transmitted by this email.
list David Gore
▸
Henrik Stoerner wrote:
On Tue, Apr 26, 2005 at 12:19:12AM +0000, David Gore wrote:Henrik Stoerner wrote:I've put together a 4.0.3rc1 package - it's available at http://www.hswn.dk/beta/hobbit-4.0.3rc1.tar.gzReplaced maint.pl in menu_items.js with hobbit-enadis.sh. IE: blank pageNothing at all ? Does anything show up if you do "View source" on this blank page ?
View source does show the relevant javascript.
▸
What happens if you run the CGI by hand like this: REQUEST_METHOD="GET" ~hobbit/server/cgi-bin/hobbit-enadis.sh
This also works and shows what would appear to be the text of the script running.
▸
Firefox: function isInternetExplorer() { ifEven more strange. Could you try and copy the files from hobbit-4.0.3rc1/hobbitd/webfiles/maint* over to ~hobbit/server/web/ Just to be sure that the new templates got installed correctly.
Did this and it still fails in the same manner as before. As a side note it does appear that when I do an install, the files group permission is not changed to the group I specified in the install. I change the cgi-bin and cgi-secure files manually to the same group id that apache uses. This has been the case a few versions back into the RC Hobbit installs. Could be some config problem, but since everything works fine with maint.pl, I am not sure what it may be? I should have stated earlier that this is on a Solaris 9 host.
Thanks, Henrik
list David Gore
Found a core: root at hobbit:/www/hobbit/cgi-secure> file core core: ELF 32-bit MSB core file SPARC Version 1, from 'hobbit-enadis.c'
▸
David Gore wrote:Henrik Stoerner wrote:On Tue, Apr 26, 2005 at 12:19:12AM +0000, David Gore wrote:Henrik Stoerner wrote:I've put together a 4.0.3rc1 package - it's available at http://www.hswn.dk/beta/hobbit-4.0.3rc1.tar.gzReplaced maint.pl in menu_items.js with hobbit-enadis.sh. IE: blank pageNothing at all ? Does anything show up if you do "View source" on this blank page ?View source does show the relevant javascript.What happens if you run the CGI by hand like this: REQUEST_METHOD="GET" ~hobbit/server/cgi-bin/hobbit-enadis.shThis also works and shows what would appear to be the text of the script running.Firefox: function isInternetExplorer() { ifEven more strange. Could you try and copy the files from hobbit-4.0.3rc1/hobbitd/webfiles/maint* over to ~hobbit/server/web/ Just to be sure that the new templates got installed correctly.Did this and it still fails in the same manner as before. As a side note it does appear that when I do an install, the files group permission is not changed to the group I specified in the install. I change the cgi-bin and cgi-secure files manually to the same group id that apache uses. This has been the case a few versions back into the RC Hobbit installs. Could be some config problem, but since everything works fine with maint.pl, I am not sure what it may be? I should have stated earlier that this is on a Solaris 9 host.Thanks, Henrik
list David Gore
An earlier core in a different directory. root at hobbit:/export/home/hobbit/server/www/menu> file core
▸
core: ELF 32-bit MSB core file SPARC Version 1, from 'hobbit-enadis.c'
David Gore wrote:Found a core: root at hobbit:/www/hobbit/cgi-secure> file core core: ELF 32-bit MSB core file SPARC Version 1, from 'hobbit-enadis.c' David Gore wrote:Henrik Stoerner wrote:On Tue, Apr 26, 2005 at 12:19:12AM +0000, David Gore wrote:Henrik Stoerner wrote:I've put together a 4.0.3rc1 package - it's available at http://www.hswn.dk/beta/hobbit-4.0.3rc1.tar.gzReplaced maint.pl in menu_items.js with hobbit-enadis.sh. IE: blank pageNothing at all ? Does anything show up if you do "View source" on this blank page ?View source does show the relevant javascript.What happens if you run the CGI by hand like this: REQUEST_METHOD="GET" ~hobbit/server/cgi-bin/hobbit-enadis.shThis also works and shows what would appear to be the text of the script running.Firefox: function isInternetExplorer() { ifEven more strange. Could you try and copy the files from hobbit-4.0.3rc1/hobbitd/webfiles/maint* over to ~hobbit/server/web/ Just to be sure that the new templates got installed correctly.Did this and it still fails in the same manner as before. As a side note it does appear that when I do an install, the files group permission is not changed to the group I specified in the install. I change the cgi-bin and cgi-secure files manually to the same group id that apache uses. This has been the case a few versions back into the RC Hobbit installs. Could be some config problem, but since everything works fine with maint.pl, I am not sure what it may be? I should have stated earlier that this is on a Solaris 9 host.Thanks, Henrik
list Bob Gordon
▸
On 4/26/05, David Gore <user-0ef10ea25696@xymon.invalid> wrote:
Nothing at all ? Does anything show up if you do "View source" on this blank page ?
View source does show the relevant javascript.
What happens if you run the CGI by hand like this: REQUEST_METHOD="GET" ~hobbit/server/cgi-bin/hobbit-enadis.shThis also works and shows what would appear to be the text of the script running.
I should have stated earlier that this is on a Solaris 9 host.
I am seeing the same issue with a Solaris 8 host..
--
--==[ Bob Gordon ]==--
list Bob Gordon
On 4/26/05, Bob Gordon <user-488dbf322a4e@xymon.invalid> wrote:
I am seeing the same issue with a Solaris 8 host..
Bit more info though.. If I attempt to go to the page from the main page (no hosts on main) then the script does not display anything. If I am on a page with hosts and hit the script, it works. Once in the script, if I remove the page filter it errors out again. -- --==[ Bob Gordon ]==--
list Bob Gordon
▸
On 4/26/05, Bob Gordon <user-488dbf322a4e@xymon.invalid> wrote:
On 4/26/05, Bob Gordon <user-488dbf322a4e@xymon.invalid> wrote:I am seeing the same issue with a Solaris 8 host..Bit more info though.. If I attempt to go to the page from the main page (no hosts on main) then the script does not display anything. If I am on a page with hosts and hit the script, it works. Once in the script, if I remove the page filter it errors out again.
Also just found a core.... Where can I send it to? -- --==[ Bob Gordon ]==--
list Henrik Størner
▸
On Tue, Apr 26, 2005 at 04:45:11PM -0700, Bob Gordon wrote:
On 4/26/05, Bob Gordon <user-488dbf322a4e@xymon.invalid> wrote:On 4/26/05, Bob Gordon <user-488dbf322a4e@xymon.invalid> wrote:I am seeing the same issue with a Solaris 8 host..Bit more info though.. If I attempt to go to the page from the main page (no hosts on main) then the script does not display anything. If I am on a page with hosts and hit the script, it works. Once in the script, if I remove the page filter it errors out again.Also just found a core.... Where can I send it to?
I got a stack trace from David that points out a problem. Could you
try this one-line patch on top of the 4.0.3rc1 ? I think it solves the
problem.
Apply with
cd hobbit-4.0.3rc1
patch -p0 </tmp/enadis-rc1.patch
make clean
make
The either "make install" and restart Hobbit, or just copy
hobbitd/hobbit-enadis.cgi over to the ~hobbit/server/bin/ directory.
Thanks,
Henrik
-------------- next part --------------
--- lib/headfoot.c 2005/04/24 21:30:43 1.28
+++ lib/headfoot.c 2005/04/26 16:58:18
@@ -610,7 +610,7 @@
xgetenv("SECURECGIBINURL"));
fprintf(output, "<table summary=\"%s disabled tests\" width=\"100%%\">\n",
- hwalk->name);
+ (hwalk->name ? hwalk->name : ""));
fprintf(output, "<tr>\n");
fprintf(output, "<TH COLSPAN=3><I>%s</I></TH>",
list Bob Gordon
▸
I got a stack trace from David that points out a problem. Could you try this one-line patch on top of the 4.0.3rc1 ? I think it solves the problem.
I don't see the core files anymore but when I remove the page filter
it still dumps out. When I enter lab as the page filter (or go to the
lab page and then to the menu option), it dumps with an "Internal
Server Error" instead of the regular "function isInternetExplorer() {
if (w" error...
--
--==[ Bob Gordon ]==--