Xymon Mailing List Archive search

Darwin clients: empty memory graph

7 messages in this thread

list Dominique Frise · Tue, 16 May 2006 16:06:04 +0200 · 
Hi,

With today's snapshot the memory graph is still empty :-(
Memory/Used/Total/Percentage info is reported correctly (only one line for 
Physical)

Same issue with Darwin 8.6.0 (OSX 10.4.6) or 7.9.0 (OSX 10.3.9)


Dominique
UNIL - University of Lausanne
list Dominique Frise · Wed, 17 May 2006 10:46:50 +0200 ·
▸ quoted from Dominique Frise
Dominique Frise wrote:
Hi,

With today's snapshot the memory graph is still empty :-(
Memory/Used/Total/Percentage info is reported correctly (only one line 
for Physical)

Same issue with Darwin 8.6.0 (OSX 10.4.6) or 7.9.0 (OSX 10.3.9)


Dominique
UNIL - University of Lausanne


We had to ack hobbitd/rrd/do_memory.c to make this work:


[super at iris rrd]# diff -u do_memory.c.dist do_memory.c
--- do_memory.c.dist	Thu May  4 17:30:37 2006
+++ do_memory.c	Wed May 17 09:44:35 2006
@@ -118,7 +118,7 @@
  		swap = strstr(msg, "Swap"); if (swap == NULL) swap = strstr(msg, "Page");
  		actual = strstr(msg, "Actual"); if (actual == NULL) actual = strstr(msg, 
"Virtual");

-		if (phys && swap) {
+		if (phys) {
  			char *eoln;
  			int physval = -1, swapval = -1, actval = -1;

@@ -125,11 +125,13 @@
  			eoln = strchr(phys, '\n'); if (eoln) *eoln = '\0';
  			physval = get_mem_percent(phys);
  			if (eoln) *eoln = '\n';
• +			if (swap) {
+				eoln = strchr(swap, '\n'); if (eoln) *eoln = '\0';
+				swapval = get_mem_percent(swap);
+				if (eoln) *eoln = '\n';
+			}

-			eoln = strchr(swap, '\n'); if (eoln) *eoln = '\0';
-			swapval = get_mem_percent(swap);
-			if (eoln) *eoln = '\n';
• if (actual) {
  				eoln = strchr(actual, '\n'); if (eoln) *eoln = '\0';
  				actval = get_mem_percent(actual);


Henrik, thanks to notice this for next snapshot.

Dominique
UNIL - University of Lausanne
list Henrik Størner · Sun, 28 May 2006 19:59:58 +0200 ·
▸ quoted from Dominique Frise
On Wed, May 17, 2006 at 10:46:50AM +0200, Dominique Frise wrote:
Dominique Frise wrote:
Hi,

With today's snapshot the memory graph is still empty :-(
Memory/Used/Total/Percentage info is reported correctly (only one line 
for Physical)
We had to ack hobbitd/rrd/do_memory.c to make this work:


[super at iris rrd]# diff -u do_memory.c.dist do_memory.c
Thanks, applied :-)

(I love it when people fix my bugs ....)


Regards,
Henrik
list Frank M. Ramaekers · Tue, 30 May 2006 10:24:35 -0500 · 
Has this been resolved?   I'm having the same problem (reporting one
item, in my case Virtual).

Thanks,
Frank
▸ quoted from Dominique Frise

-----Original Message-----
From: Dominique Frise [mailto:user-78ab6673b600@xymon.invalid] 
Sent: Wednesday, May 17, 2006 3:47 AM
To: user-ae9b8668bcde@xymon.invalid
Subject: Re: [hobbit] Darwin clients: empty memory graph

Dominique Frise wrote:
Hi,

With today's snapshot the memory graph is still empty :-(
Memory/Used/Total/Percentage info is reported correctly (only one line
for Physical)

Same issue with Darwin 8.6.0 (OSX 10.4.6) or 7.9.0 (OSX 10.3.9)


Dominique
UNIL - University of Lausanne


We had to ack hobbitd/rrd/do_memory.c to make this work:


[super at iris rrd]# diff -u do_memory.c.dist do_memory.c
--- do_memory.c.dist	Thu May  4 17:30:37 2006
+++ do_memory.c	Wed May 17 09:44:35 2006
@@ -118,7 +118,7 @@
  		swap = strstr(msg, "Swap"); if (swap == NULL) swap =
strstr(msg, "Page");
  		actual = strstr(msg, "Actual"); if (actual == NULL)
actual = strstr(msg, 
"Virtual");

-		if (phys && swap) {
+		if (phys) {
  			char *eoln;
  			int physval = -1, swapval = -1, actval = -1;

@@ -125,11 +125,13 @@
  			eoln = strchr(phys, '\n'); if (eoln) *eoln =
'\0';
  			physval = get_mem_percent(phys);
  			if (eoln) *eoln = '\n';
• +			if (swap) {
+				eoln = strchr(swap, '\n'); if (eoln)
*eoln = '\0';
+				swapval = get_mem_percent(swap);
+				if (eoln) *eoln = '\n';
+			}

-			eoln = strchr(swap, '\n'); if (eoln) *eoln =
'\0';
-			swapval = get_mem_percent(swap);
-			if (eoln) *eoln = '\n';
• if (actual) {
  				eoln = strchr(actual, '\n'); if (eoln)
*eoln = '\0';
  				actval = get_mem_percent(actual);


Henrik, thanks to notice this for next snapshot.

Dominique
UNIL - University of Lausanne



This message contains information which is privileged and confidential and is solely for the use of the intended recipient.  If you are not the intended recipient, be aware that any review, disclosure, copying, distribution, or use of the contents of this message is strictly prohibited. If you have received this in error, please destroy it immediately and notify us at user-2f780dbd82da@xymon.invalid.
list Henrik Størner · Tue, 30 May 2006 18:05:58 +0200 ·
▸ quoted from Frank M. Ramaekers
On Tue, May 30, 2006 at 10:24:35AM -0500, Frank M. Ramaekers wrote:
Has this been resolved?   I'm having the same problem (reporting one
item, in my case Virtual).
I committed that change to my source code Sunday evening, so yes - 
this should be fixed now.


Regards,
Henrik
list Frank M. Ramaekers · Tue, 30 May 2006 11:25:30 -0500 · 
What is the URL for the snapshot?   (Sorry, had to rebuild the hard
drive and lost all of my bookmarks).

TIA,
Frank
▸ quoted from Frank M. Ramaekers

-----Original Message-----
From: Henrik Stoerner [mailto:user-ce4a2c883f75@xymon.invalid] 
Sent: Tuesday, May 30, 2006 11:06 AM
To: user-ae9b8668bcde@xymon.invalid
Subject: Re: [hobbit] Darwin clients: empty memory graph

On Tue, May 30, 2006 at 10:24:35AM -0500, Frank M. Ramaekers wrote:
Has this been resolved?   I'm having the same problem (reporting one
item, in my case Virtual).
I committed that change to my source code Sunday evening, so yes - 
this should be fixed now.


Regards,
Henrik


This message contains information which is privileged and confidential and is solely for the use of the intended recipient.  If you are not the intended recipient, be aware that any review, disclosure, copying, distribution, or use of the contents of this message is strictly prohibited. If you have received this in error, please destroy it immediately and notify us at user-2f780dbd82da@xymon.invalid.
list David Gore · Tue, 30 May 2006 16:29:25 +0000 · 
http://hswn.dk/beta/

Frank M. Ramaekers wrote:
What is the URL for the snapshot?   (Sorry, had to rebuild the hard
drive and lost all of my bookmarks).

TIA,
Frank

-----Original Message-----
From: Henrik Stoerner [mailto:user-ce4a2c883f75@xymon.invalid] 
Sent: Tuesday, May 30, 2006 11:06 AM
To: user-ae9b8668bcde@xymon.invalid
Subject: Re: [hobbit] Darwin clients: empty memory graph

On Tue, May 30, 2006 at 10:24:35AM -0500, Frank M. Ramaekers wrote:
  
Has this been resolved?   I'm having the same problem (reporting one
item, in my case Virtual).
    
I committed that change to my source code Sunday evening, so yes - 
this should be fixed now.


Regards,
Henrik


This message contains information which is privileged and confidential and is solely for the use of the intended recipient.  If you are not the intended recipient, be aware that any review, disclosure, copying, distribution, or use of the contents of this message is strictly prohibited. If you have received this in error, please destroy it immediately and notify us at user-2f780dbd82da@xymon.invalid.