RECOVERED alerts still sent outside of TIME window
list Eric E *hs Schwimmer
Howdy all, We just had one of our engineers get a rude awakening last night by a UPS that had recovered from an error; I had thought that the RECOVERED pages were under the same TIME restrictions as normal alerts, but a quick look at the code leads me to believe that this is not so. Before I (or somebody else ;) attempts a fix, I wanted to make sure that there wasn't a valid reason behind this implementation. (I'm looking at the criteria match routine in the do_alerts.c file, specifically lines 899 through 914). TIA, -Eric Schwimmer Network Engineer UVA HSCS Network Engineering
list Henrik Størner
Hi Eric,
▸
On Thu, Dec 08, 2005 at 11:19:15AM -0500, Schwimmer, Eric E *HS wrote:We just had one of our engineers get a rude awakening last night by a UPS that had recovered from an error; I had thought that the RECOVERED pages were under the same TIME restrictions as normal alerts, but a quick look at the code leads me to believe that this is not so.
you're right that the recovery-messages are not filtered through the TIME restrictions. I seem to recall there was a bit of discussion about this quite some time ago, where some people requested that they be informed about recoveries, whether they were inside the time-window or not. After thinking about this for 5 minutes, I've decided to change the behaviour so recovery messages are dropped if they happen outside of the permitted TIME setting. If anyone thinks this is wrong, speak up now. Regards, Henrik
list Greg L Hubbard
Maybe you need a "RECOVERED=ALWAYS" option for those who want to know that things that they didn't receive a notification about are now fixed... (or NUISANCE=FULL or ...) I personally prefer the approach you just suggested... GLH
▸
-----Original Message-----
From: Henrik Stoerner [mailto:user-ce4a2c883f75@xymon.invalid]
Sent: Monday, May 29, 2006 4:29 PM
To: user-ae9b8668bcde@xymon.invalid
Subject: Re: [hobbit] RECOVERED alerts still sent outside of TIME window
Hi Eric,
On Thu, Dec 08, 2005 at 11:19:15AM -0500, Schwimmer, Eric E *HS wrote:We just had one of our engineers get a rude awakening last night by a UPS that had recovered from an error; I had thought that the RECOVERED pages were under the same TIME restrictions as normal alerts, but a quick look at the code leads me to believe that this is not so.
you're right that the recovery-messages are not filtered through the TIME restrictions. I seem to recall there was a bit of discussion about this quite some time ago, where some people requested that they be informed about recoveries, whether they were inside the time-window or not. After thinking about this for 5 minutes, I've decided to change the behaviour so recovery messages are dropped if they happen outside of the permitted TIME setting. If anyone thinks this is wrong, speak up now. Regards, Henrik