Xymon Mailing List Archive search

Bbnet-test.c

4 messages in this thread

list Andy Farrior · Tue, 5 Jul 2005 11:43:36 -0500 ·
Henrik,

If you don't see a problem with it, could you captilize "not" in the
messages generated by bbtest-net.c?


$ grep -nw "OK" bbtest-net.c
1602:                             strcat(msgtext, "OK ");
1620:                                   strcat(msgtext, "not OK.\nThe
");
1628:                                   strcat(msgtext, "not OK : ");
1635:                             strcat(msgtext, "OK\n");
1675:                             strcat(msgtext, "OK\n");


I've had a few techs who only read the message body and not the subjet
line and don't notice the "not" in "not OK" when the conn status is red.
They see "OK" and think all is well....

I'm training them to read the subject heading first, but thought this
might be minor change you'd like.

Thanks,
Andy


---
Andrew Farrior                          o) XXX.XXX.XXXX
Director of Technology Services         f) XXX.XXX.XXXX   
Victoria College                       
2200 E Red River
Victoria, TX XXXXX
mailto:user-ca324d8ab782@xymon.invalid
list Adam Goryachev · Wed, 06 Jul 2005 03:02:29 +1000 ·
quoted from Andy Farrior
On Tue, 2005-07-05 at 11:43 -0500, FARRIOR, Andy wrote:
Henrik,

If you don't see a problem with it, could you captilize "not" in the
messages generated by bbtest-net.c?


$ grep -nw "OK" bbtest-net.c
1602:                             strcat(msgtext, "OK ");
1620:                                   strcat(msgtext, "not OK.\nThe
");
1628:                                   strcat(msgtext, "not OK : ");
1635:                             strcat(msgtext, "OK\n");
1675:                             strcat(msgtext, "OK\n");


I've had a few techs who only read the message body and not the subjet
line and don't notice the "not" in "not OK" when the conn status is red.
They see "OK" and think all is well....

I'm training them to read the subject heading first, but thought this
might be minor change you'd like.
Well, if you really wanted something different (but short) how about
"BAD" or FAIL, this removes the need to grok multiple words....
However, this might cause issues for other people who have tools which
depend on the output....

Mind you, so does capitalising not -> NOT cause the same problem.

Regards,
Adam

-- 
 -- 
Adam Goryachev
Website Managers
Ph:  +XX X XXXX XXXX                        user-eaec2ffb4cbc@xymon.invalid
Fax: +XX X XXXX XXXX                        www.websitemanagers.com.au
list Henrik Størner · Tue, 5 Jul 2005 20:49:59 +0200 ·
quoted from Adam Goryachev
On Tue, Jul 05, 2005 at 11:43:36AM -0500, FARRIOR, Andy wrote:
If you don't see a problem with it, could you captilize "not" in the
messages generated by bbtest-net.c?

I've had a few techs who only read the message body and not the subjet
line and don't notice the "not" in "not OK" when the conn status is red.
They see "OK" and think all is well....
I'll leave the default as-is, but you can now customize it as you like
by setting a NETFAILTEXT variable in hobbitserver.cfg. You can make it
"FAILED", "NOT ok", "has gone belly-up", ...


Regards,
Henrik
list Andy Farrior · Tue, 5 Jul 2005 14:08:59 -0500 ·
Ahh!!!

It helps to read the Changes file for the beta releases....

I was working with 4.0.4. 
quoted from Henrik Størner

-----Original Message-----
From: Henrik Stoerner [mailto:user-ce4a2c883f75@xymon.invalid] 
Sent: Tuesday, July 05, 2005 1:50 PM
To: user-ae9b8668bcde@xymon.invalid
Subject: Re: [hobbit] Bbnet-test.c

On Tue, Jul 05, 2005 at 11:43:36AM -0500, FARRIOR, Andy wrote:
If you don't see a problem with it, could you captilize "not" in the
messages generated by bbtest-net.c?

I've had a few techs who only read the message body and not the subjet
line and don't notice the "not" in "not OK" when the conn status is
red.
They see "OK" and think all is well....
I'll leave the default as-is, but you can now customize it as you like
by setting a NETFAILTEXT variable in hobbitserver.cfg. You can make it
"FAILED", "NOT ok", "has gone belly-up", ...


Regards,
Henrik