Xymon Mailing List Archive search

Problem with msgcache ... (and Fix!)

2 messages in this thread

list Rolf Masfelder · Tue, 19 Sep 2006 22:41:33 +0200 ·
Hello Henrik,

because there are others which can't reach you via private mail, I send 
you this info thru the list.

Thanx for your great work

Rolf

----------  Weitergeleitete Nachricht  ----------

Subject: Problem with msgcache ... (and Fix!)
Date: Freitag 15 September 2006 10:42
From: Rolf Masfelder <user-7583fc084b48@xymon.invalid>
To: Henrik Stoerner <user-ce4a2c883f75@xymon.invalid>

Hello Henrik,

in msgcache.c is a problem if a second (or third or ...) connection at
the same time is stored in your connection-list.

so (line 443):

		if (!chead) ctail = NULL;

should be replaced with :

                ctail = chead;
                if (ctail) { while (ctail->next) ctail = ctail->next; }

to store a new connection at the end of the list (you handle the
message-queue  in the same way).

Thanx for the great work
--
Rolf Masfelder

Tel.:	XXXXX XXX XXX
FAX:	XXXXX XXX XXX
Mobil:	XXXX XX XX XXX
world:	0700 NECTORGMbh
EMail: 	user-7583fc084b48@xymon.invalid

http://www.nector.de


-- 
Rolf Masfelder

Tel.:	XXXXX XXX XXX
FAX:	XXXXX XXX XXX
Mobil:	XXXX XX XX XXX
world:	0700 NECTORGMbh
EMail: 	user-7583fc084b48@xymon.invalid

http://www.nector.de
list Henrik Størner · Wed, 20 Sep 2006 22:31:52 +0200 ·
quoted from Rolf Masfelder
On Tue, Sep 19, 2006 at 10:41:33PM +0200, Rolf Masfelder wrote:
in msgcache.c is a problem if a second (or third or ...) connection at
the same time is stored in your connection-list.

so (line 443):

		if (!chead) ctail = NULL;

should be replaced with :

                ctail = chead;
                if (ctail) { while (ctail->next) ctail = ctail->next; }

to store a new connection at the end of the list (you handle the
message-queue  in the same way).
Good catch, thanks. Applied, and there's a patch for it on the patches
page shortly.


Regards,
Henrik