Xymon Mailing List Archive search

hobbitcgi.cfg CGI_GHOSTS_OPT mistype

4 messages in this thread

list Paul Moore · Mon, 20 Oct 2008 16:31:38 +0000 ·
Henrik,

 
I don't know if you are still maintaining the 4.2.0 version, but I have
stumbled across a mistype in the hobbitcgi.cfg file that gets created.

 
#hobbit-ghosts.cgi options

CGI_GHOSTS_OPT="--env=/usr/local/hobbit/server/etc/hobbitserver.cfg"

 
However, in the hobbit-ghosts.sh file you call it differently.

 
more hobbit-ghosts.sh

#!/bin/sh

 
# This is the Hobbit wrapper for the ghosts CGI

 
. /opt/tools/hobbit/server/etc/hobbitcgi.cfg

 exec /usr/local/hobbit/server/bin/hobbit-ghosts.cgi
--env=/usr/local/hobbit/server/etc/hobbitserver.cfg $CGI_GHOSTS_OPTS

 
You have dropped the S off the end of the variable $CGI_GHOSTS_OPTS.
This only caused me trouble when building a package and the compiled
variables for serverip did not "exist" 

 
Paul Moore
Verizon Business
MNSO OSS - Principal Engineer
XXXX Weston Parkway
Cary, NC XXXXX
 
Office: X-XXX-XXX-XXXX
Vnet: 966-5159
Cell: X-XXX-XXX-XXXX
user-8c3a430470a0@xymon.invalid
http://mnso.mcilink.com/oss
list Henrik Størner · Mon, 20 Oct 2008 20:40:31 +0000 (UTC) ·
quoted from Paul Moore
In <user-4476ab6f3552@xymon.invalid> "Moore, Paul" <user-8c3a430470a0@xymon.invalid> writes:
I don't know if you are still maintaining the 4.2.0 version, but I have
stumbled across a mistype in the hobbitcgi.cfg file that gets created.
[snip]
You have dropped the S off the end of the variable $CGI_GHOSTS_OPTS.
Thanks, fixed now in what will be the 4.3 version.


Regards,
Henrik
list Ndegz · Mon, 20 Oct 2008 17:01:07 -0400 ·
Is the fix in hobbit_ghosts.sh or hobbitcgi.cfg? In other words which is the
correct variable?
Regards
NNdegz
quoted from Henrik Størner

On Mon, Oct 20, 2008 at 4:40 PM, Henrik Stoerner <user-ce4a2c883f75@xymon.invalid> wrote:
In <user-4476ab6f3552@xymon.invalid>
"Moore, Paul" <user-8c3a430470a0@xymon.invalid> writes:
I don't know if you are still maintaining the 4.2.0 version, but I have
stumbled across a mistype in the hobbitcgi.cfg file that gets created.
[snip]
You have dropped the S off the end of the variable $CGI_GHOSTS_OPTS.
Thanks, fixed now in what will be the 4.3 version.


Regards,
Henrik

list Robert Holden · Mon, 20 Oct 2008 15:20:06 -0700 ·
I would suggest that the change be made to the hobbitcgi.cfg file as similar
variables all end in _OPTS.

*** Another change that will need to be made is adding the variable
CGI_NOTIFYLOG_OPTS as this one is missing from hobbitcgi.cfg.  This variable
is referenced in hobbit-notifylog.sh.

Finally, another file to change is the RELEASENOTES.  It references the
CGI_GHOSTS_OPT (no S) name and is also missing the CGI_NOTIFYLOG_OPTS
variable.

If you like, I can create a patch file.

Robert
quoted from Ndegz


On Mon, Oct 20, 2008 at 2:01 PM, ndegz <user-8b9b995f074d@xymon.invalid> wrote:
Is the fix in hobbit_ghosts.sh or hobbitcgi.cfg? In other words which is
the correct variable?
Regards
NNdegz


On Mon, Oct 20, 2008 at 4:40 PM, Henrik Stoerner <user-ce4a2c883f75@xymon.invalid> wrote:
In <user-4476ab6f3552@xymon.invalid>
"Moore, Paul" <user-8c3a430470a0@xymon.invalid> writes:
I don't know if you are still maintaining the 4.2.0 version, but I have
stumbled across a mistype in the hobbitcgi.cfg file that gets created.
[snip]
You have dropped the S off the end of the variable $CGI_GHOSTS_OPTS.
Thanks, fixed now in what will be the 4.3 version.


Regards,
Henrik