Xymon Mailing List Archive search

DISPLAYGROUP fails in analysis.cfg

list Jeremy Laidman
Fri, 1 Feb 2019 19:40:06 +1100
Message-Id: <CACO=user-8b09ca337e66@xymon.invalid>

On Fri, 1 Feb 2019 at 10:48, Dave "doughnut" Fogarty <user-138a88324cb7@xymon.invalid>
wrote:
Looks like I just found my answer in the source code.  This is actually
broken due to someone counting the number of characters incorrectly for a
strncasecmp in client_config.c.  It's done correctly later in the same
code.  This should be "13" and "15" where it's "12" and "14".

$ grep -n DISPLAYGROUP= client_config.c
466:         (strncasecmp(token, "DISPLAYGROUP=", 12) == 0)     ||
467:         (strncasecmp(token, "EXDISPLAYGROUP=", 14) == 0)   ||
667:                    else if (strncasecmp(tok, "DISPLAYGROUP=", 13) ==
0) {
673:                    else if (strncasecmp(tok, "EXDISPLAYGROUP=", 15)
== 0) {
Very nice detective work, Dave. Have you re-compiled with adjustments and
re-tested?

J