Xymon Mailing List Archive search

Segfault in confreport-critical.sh / confreport.cgi in 4.3.24 (now with backtrace)

list Japheth Cleaver
Thu, 10 Dec 2015 09:22:37 -0800
Message-Id: <user-a82e37c04ead@xymon.invalid>

On Thu, December 10, 2015 8:53 am, Axel Beckert wrote:
Hi JC,

On Thu, Dec 10, 2015 at 08:23:23AM -0800, J.C. Cleaver wrote:
Can you see if this patch helps?
The patched helped, thanks! Can't reproduce the issue anymore.
Perfect, thanks!

-jc


(From earlier)
--- web/confreport.c	(revision 7835)
+++ web/confreport.c	(working copy)
@@ -288,9 +288,10 @@
 		}
 		else if (is_net_test(itm)) {
 			colname = strdup(itm);
+			visdata = strdup("");
 		}

• +		if (!visdata) visdata = strdup("");
Those two additionans look a little bit redundant, but that shouldn't
cause any harm. (I'd say the first addition shouldn't be necessary
if the second one is present.)
That's correct. I added that primarily because of the structures above it
(which all set visdata), and because I wasn't quite sure of ultimate
source of some of this, and what was liable to fall through or not.