On Wed, Apr 20, 2005 at 09:55:59PM -0400, Tom Georgoulias wrote:
One of the downsides to the way the current enable/disable maint.pl works is the way the trend charts do not continue using data collected from clients after the tests are disabled. For example if I disable disk tests for a server, the BB client still sends the data to hobbit and the latest values are displayed, but those values aren't put into the graphs. As a result, I have large blank gaps in spots when a test was disabled. I can understand the presence of these gaps when a client is offline, but if I'm getting the data but just don't want be bothered with pager alerts from a server issue I'm already aware of, shouldn't that be OK?
It should, and I actually thought Hobbit was already working that
way. But no - I forgot to send "blue" status reports through to the
RRD update routine.
Patch is attached.
BTW, I expect to release a 4.0.3 version over the week-end with the
patches that have accumulated, and the new enable/disable tool. Before
Lars objects - I think I have found out what why it is hanging for
you, so I'll send you a patch later today for testing.
Regards,
Henrik
--
Henrik Storner
-------------- next part --------------
--- hobbitd/hobbitd_larrd.c 2005/03/25 21:13:41 1.17
+++ hobbitd/hobbitd_larrd.c 2005/04/21 07:40:58
@@ -12,7 +12,7 @@
/* */
/*----------------------------------------------------------------------------*/
-static char rcsid[] = "$Id: hobbitd_larrd.c,v 1.17 2005/03/25 21:13:41 henrik Exp $";
+static char rcsid[] = "$Id: hobbitd_larrd.c,v 1.18 2005/04/21 07:40:46 henrik Exp $";
#include <stdio.h>
#include <string.h>
@@ -175,6 +175,7 @@
case COL_GREEN:
case COL_YELLOW:
case COL_RED:
+ case COL_BLUE: /* Blue is OK, because it only arrives here when an update is sent */
tstamp = atoi(metadata[1]);
sender = metadata[2];
hostname = metadata[4];