Xymon Mailing List Archive search

overflow in netbsd-meminfo.c

list Tracy di Marco White
Wed, 12 Nov 2008 22:27:22 -0600
Message-Id: <user-760af57f5019@xymon.invalid>

On Wed, Nov 12, 2008 at 10:06 PM, Rich Smrcina <user-cf452ff334e0@xymon.invalid> wrote:
Tracy Di Marco White wrote:
Hobbit client 4.2.0 shows things like this on machines I have
with 4GB of RAM:
  Memory              Used       Total  Percentage
 Physical     4294963639M 4294966523M          0%
 Swap                  0M       4098M          0%

With this patch it's better:
--- client/netbsd-meminfo.c.orig        2008-11-12 19:25:30.000000000
-0600
+++ client/netbsd-meminfo.c
@@ -22,7 +22,7 @@ static char rcsid[] = "$Id: netbsd-memin
 int main(int argc, char *argv[])
 {
       int hw_physmem[] = { CTL_HW, HW_PHYSMEM };
-       int physmem;
+       unsigned long physmem;
         int hw_pagesize[] = { CTL_HW, HW_PAGESIZE };
       int pagesize;
That appears to be a bug in netbsd.
This is what it appears as in meminfo for one of my 4GB machines:
[meminfo]
Total:-773
Free:2884
Swaptotal:4098
Swapused:0

Since freebsd-meminfo.c seems to be using unsigned long in the same
place I modified it, I'm not sure it's a bug only in NetBSD.

-Tracy