Xymon Mailing List Archive search

bbtest-net crash: 4.2 RC with (fixed) all-in-one patch

list Henrik Størner
Mon, 7 Aug 2006 18:28:01 +0200
Message-Id: <user-7e78fb6bd687@xymon.invalid>

On Mon, Aug 07, 2006 at 12:13:48PM -0400, John Payne wrote:
I'm a new subscriber, been busy reading the archives.

First off... I don't think I saw this patch go through which fixes a  problem exposed by the all-in-one patch:

*** hobbitd/hobbitd_alert.c.old Fri Aug  4 17:55:04 2006
--- hobbitd/hobbitd_alert.c     Fri Aug  4 17:55:16 2006
I got this one just a few hours ago from another person, so it is
actually fixed already. 
*** bbnet/bbtest-net.c.old      Mon Aug  7 12:06:27 2006
--- bbnet/bbtest-net.c  Mon Aug  7 12:07:28 2006
                /* parent */
!               char ip[IP_ADDR_STRLEN+1];

IP_ADDR_STRLEN is defined to be 16, but in start_ping_service, it's  being used:

sprintf(ip, "%s\n", ip_to_test(t->host));
Good catch! Applied.


Thanks,
Henrik