Hi David
First of all, thanks for providing us with a great starting point with the Powershell client.
We've discussed this in-house and agree that the best long term solution would be to fix/extend the server code. Now, it's been a long time since I looked at any C code, but it looks to me (looking at commit 7594 in trunk) that do_ifstat.c needs the following addition:
case OS_SCO_SV:
if (pickdata(bol, ifstat_sco_sv_pcres[0], 0, &ifname, &rxstr, &txstr)) dmatch = 7;
break;
+ case OS_WIN32_POWERSHELL:
case OS_WIN32_BBWIN:
if (pickdata(bol, ifstat_bbwin_pcres[0], 0, &ifname, &rxstr, &txstr)) dmatch = 7;
break;
Zak
From: David Baldwin [mailto:user-cbbf693f2c89@xymon.invalid]
Sent: 04 March 2015 23:50
To: Jeremy Laidman; Beck, Zak
Subject: Re: [Xymon] Xymon PowerShell Windows client
On 5/03/15 10:00 AM, Jeremy Laidman wrote:
On 04/03/2015 7:49 PM, <user-aada0fa38bf8@xymon.invalid <mailto:user-aada0fa38bf8@xymon.invalid> > wrote:Unfortunately, you can't fake the BBWin identifier for just one section – you have to change the client to report in as BBwin. It was changed so that we could experimentally use separate configuration options for BBWin clients and Powershell clients.
Of course the best option is to extend the server to match the features of the client. It wouldn't take much (like one line) to add the powershell OS into the ifstat handler, running the same code as for bbwin.
I took a look at the current code in trunk today - the powershell client (however that is detected) looks like it is treated the same as BBWin at present. Server-side extension in the C code is fine for those comfortable with that, but makes it difficult for those wanting to just try out the new client against an existing server.
David.
J
--
David Baldwin - Senior Systems Administrator (Datacentres + Networks)
Information and Communication Technology Services
Australian Sports Commission http://ausport.gov.au
Tel 02 62147830 Fax 02 62141830 PO Box 176 Belconnen ACT 2616
user-cbbf693f2c89@xymon.invalid <mailto:user-cbbf693f2c89@xymon.invalid> 1 Leverrier Street Bruce ACT 2617
Our Values: RESPECT + INTEGRITY + TEAMWORK + EXCELLENCE
Keep up to date with what's happening in Australian sport visit www.ausport.gov.au <http://www.ausport.gov.au>;
This message is intended for the addressee named and may contain confidential and privileged information. If you are not the intended recipient please note that any form of distribution, copying or use of this communication or the information in it is strictly prohibited and may be unlawful. If you receive this message in error, please delete it and notify the sender.