Xymon Mailing List Archive search

badTEST:x:y:z not working

list Eric van de Meerakker
Tue, 23 Aug 2005 09:56:32 +0200
Message-Id: <user-ec55102168b4@xymon.invalid>

Hello Henrik,


Just to confirm this: your patch seems to be working OK. I set
"badhttp:0:1:2" and have now seen the http test go from green to yellow
before turning red.

Thanks! This will keep down the number of false alerts.


Eric

mail to : user-004bb4e22963@xymon.invalid
phone   : +XX (X)XX XXX XXXX
fax     : +XX (X)XX XXX XXXX


-----Original Message-----
From: Henrik Stoerner [mailto:user-ce4a2c883f75@xymon.invalid] 
Sent: Thursday, August 11, 2005 3:49 PM
To: user-ae9b8668bcde@xymon.invalid
Subject: Re: [hobbit] badTEST:x:y:z not working

On Thu, Aug 11, 2005 at 01:46:16PM +0200, user-c9ab24a501e1@xymon.invalid wrote:
Dear all,
 
looks to me, as if the "badTEST:x:y:z" tags are not working. 
 
I.e. "badssh:1:2:3" turns immediatley red if ssh goes down at the
monitored host. 
There has been some reports about this, but I never got around to
looking into exactly what caused it.
I've looked into bbtest-net.c and figured out, that ..
 
- At line 775, the for loop << "for (swalk=svchead; (swalk &&
strcmp(swalk->testname, testname)); swalk = swalk->next) >>
compares swalk->testname and testname ---> which are never equal, because
the string testname always includes the :x.y:z settings and swalk->testname
(of course) not.

Aha - that would explain it.

I think this patch should fix it, then.


Henrik