Xymon Mailing List Archive search

error in hobbitsvc.c?

list Ulric Eriksson
Thu, 27 Mar 2008 17:59:04 +0100 (CET)
Message-Id: <user-ab6a14c669ab@xymon.invalid>

On Thu, 27 Mar 2008, Dirk Kastens wrote:
I just looked through the code of the latest snapshot. I'm not a 
C-programmer, but aren't there some brackets missing on line 342:

modifiers = (items[19] && *(items[19])) ? items[19] : NULL;

Shouldn't this be:

modifiers = ((items[19] && *(items[19])) ? items[19] : NULL);
Operator precedence makes those two expressions equivalent.

http://en.wikipedia.org/wiki/Operators_in_C_and_C%2B%2B#Operator_precedence

Ulric