Xymon Mailing List Archive search

Column order and accessibility of the 'info' column

list Henrik Størner
Fri, 17 Jan 2014 12:12:30 +0100
Message-Id: <user-0ca49b1c1323@xymon.invalid>

Den 16.01.2014 21:22, John Thurston skrev:
We're finding the 'info' column to be very important to us, but are
also finding it a little difficult to find in the web displays.

Since the number and titles of the columns displayed for each group
vary, it is impossible to know which green diamond is the 'info'
column without consulting the group-header. Is is difficult in a
couple of cases:
  + If there are many hosts in a group, it can be hard to do the
     row/column matching to click the correct 'info' button.
  + If we use the 'find host/jump' function, the found host is
     at the top of the page and we must scroll up to find the header.

I can think of several ways to make this more usable:
  + Use a unique icon (or icon set) for 'info'. Is 'info' ever
     be anything but green?
I like the idea of a different icon for the info-column. Try this patch, it causes the info-column to use the "unknown.gif" icon which contains a question-mark.
NB: You may have to patch with "--ignore-whitespace" in case tabs/spaces get messed up in copy-paste operation.

Regards,
Henrik

Index: xymongen/pagegen.c
===================================================================
--- xymongen/pagegen.c  (revision 7347)
+++ xymongen/pagegen.c  (working copy)
@@ -553,10 +553,12 @@
                                 else if (reportstart == 0) {
                                         /* Standard webpage */
                                         char *skin;
+                                       char *img = dotgiffilename(e->color, e->acked, e->oldage);

                                         if (strcmp(e->column->name, xgetenv("INFOCOLUMN")) == 0) {
                                                 /* Show the host IP on the hint display of the "info" column */
                                                 htmlalttag = alttag(e->column->name, COL_GREEN, 0, 1, h->ip);
+                                               img = dotgiffilename(-1, 0, 0);
                                         }
                                         else {
                                                 htmlalttag = alttag(e->column->name, e->color, e->acked, e->propagate, e->age);
@@ -586,7 +588,7 @@
                                         }

                                         fprintf(output, "<IMG SRC=\"%s/%s\" ALT=\"%s\" TITLE=\"%s\" HEIGHT=\"%s\" WIDTH=\"%s\" BORDER=0></A>",
-                                               skin, dotgiffilename(e->color, e->acked, e->oldage),
+                                               skin, img,
                                                 htmlalttag, htmlalttag,
                                                 xgetenv("DOTHEIGHT"), xgetenv("DOTWIDTH"));